Prevent the while loop to be executing too long#1073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at e2ef40f
Add pagination support to
getIntegrationRunsfunction inintegrationRunRepository.ts. This allows fetching integration runs by batches based on their creation date.
🤖 Generated by Copilot at e2ef40f
Why
Because the rows are not always changed the results are most of the times the same so the while loops loops almost for ever.
How
🤖 Generated by Copilot at e2ef40f
lastCreatedAtparameter togetIntegrationRunsfunction to filter integration runs by maximum creation date (link)lastCreatedAtparameter and append it to existingwhereclause withandoperator (link)whereclause inbackend/src/database/repositories/integrationRunRepository.ts(link)Checklist ✅
Feature,Improvement, orBug.Add screehshots to the PR description for relevant FE changesNew backend functionality has been unit-tested.API documentation has been updated (if necessary) (see docs on API documentation).